Skip to content

Fix milestone whitelist delay on restart#1611

Merged
cffls merged 1 commit intomasterfrom
milestone_whitelist_hotfix
Jul 3, 2025
Merged

Fix milestone whitelist delay on restart#1611
cffls merged 1 commit intomasterfrom
milestone_whitelist_hotfix

Conversation

@cffls
Copy link
Copy Markdown
Contributor

@cffls cffls commented Jul 3, 2025

Description

This is to fix a problem when the node is stuck at a loop when it is initially started and trying to whitelist the first milestone. Instead of tracking all the block from the genesis, the metrics should just update the from the start block in the milestone.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

This is to fix a problem when the node is stuck at a loop when it is initially started and trying to whitelist the first milestone.
Instead of tracking all the block from the genesis, the metrics should just update the from the start block in the milestone.
@cffls cffls requested review from a team and lucca30 July 3, 2025 20:36
Copy link
Copy Markdown
Contributor

@lucca30 lucca30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@cffls cffls requested a review from a team July 3, 2025 20:47
@cffls cffls merged commit 8eaf4bb into master Jul 3, 2025
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants