Merged
Conversation
Member
Author
|
This is failing because of the upload logs case, and not because of the changes I made. The smoke test passes successfully. |
marcello33
approved these changes
Jun 30, 2025
manav2401
approved these changes
Jul 1, 2025
Member
manav2401
left a comment
There was a problem hiding this comment.
LGTM, might be worth extending this approach to send L1 to L2 bridge transactions from different (at least 2) accounts instead of sending all from a single account.
Member
Author
|
Yeah, good point. I can make a follow-up PR to do this. Merging this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description