Skip to content

consensus/bor, params: added OverrideStateSyncRecordsInRange to overwrite the state sync records for a range of blocks#1597

Merged
pratikspatil024 merged 1 commit intov2.2.4-beta-candidatefrom
psp-OverrideStateSyncs
Jun 27, 2025
Merged

consensus/bor, params: added OverrideStateSyncRecordsInRange to overwrite the state sync records for a range of blocks#1597
pratikspatil024 merged 1 commit intov2.2.4-beta-candidatefrom
psp-OverrideStateSyncs

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 commented Jun 27, 2025 •
edited
Loading

Description

Added OverrideStateSyncRecordsInRange to overwrite the state sync records for a range of blocks.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@pratikspatil024 pratikspatil024 requested review from a team and cffls June 27, 2025 03:54
@pratikspatil024 pratikspatil024 added the do not squash and merge This PR will be NOT be squashed and merged label Jun 27, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.2.4-beta-candidate@80ee5b1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
params/config.go 0.00% 6 Missing ⚠️
consensus/bor/bor.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##             v2.2.4-beta-candidate    #1597   +/-   ##
========================================================
  Coverage                         ?   48.17%           
========================================================
  Files                            ?      819           
  Lines                            ?   132526           
  Branches                         ?        0           
========================================================
  Hits                             ?    63849           
  Misses                           ?    64552           
  Partials                         ?     4125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratikspatil024 pratikspatil024 force-pushed the psp-OverrideStateSyncs branch from f604b9b to ca04eb3 Compare June 27, 2025 04:50
ssandeep
ssandeep reviewed Jun 27, 2025
View reviewed changes
@pratikspatil024 pratikspatil024 force-pushed the psp-OverrideStateSyncs branch from ca04eb3 to 40c2ec4 Compare June 27, 2025 04:58
@pratikspatil024 pratikspatil024 changed the title consensus/bor, params, amoy: added OverrideStateSyncRecordsInRange to overwrite the state sync records for a range of blocks consensus/bor, params: added OverrideStateSyncRecordsInRange to overwrite the state sync records for a range of blocks Jun 27, 2025
@pratikspatil024 pratikspatil024 removed the do not squash and merge This PR will be NOT be squashed and merged label Jun 27, 2025
@pratikspatil024
consensus/bor, params: added OverrideStateSyncRecordsInRange to overw…
23688d6 
…rite the state sync records for a range of blocks
@pratikspatil024 pratikspatil024 force-pushed the psp-OverrideStateSyncs branch from 40c2ec4 to 23688d6 Compare June 27, 2025 08:52
@pratikspatil024 pratikspatil024 merged commit 4cb5750 into v2.2.4-beta-candidate Jun 27, 2025
7 of 8 checks passed
@pratikspatil024 pratikspatil024 deleted the psp-OverrideStateSyncs branch June 27, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cffls cffls cffls approved these changes

+2 more reviewers

@ssandeep ssandeep ssandeep left review comments

@Raneet10 Raneet10 Raneet10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pratikspatil024 @ssandeep @Raneet10 @cffls