Skip to content

fix(consensus, span): avoid duplicate span commit for spanId 1#1559

Merged
kamuikatsurgi merged 3 commits intodevelopfrom
krishang/dup-span-commit-fix
Jun 2, 2025
Merged

fix(consensus, span): avoid duplicate span commit for spanId 1#1559
kamuikatsurgi merged 3 commits intodevelopfrom
krishang/dup-span-commit-fix

Conversation

@kamuikatsurgi
Copy link
Copy Markdown
Member

@kamuikatsurgi kamuikatsurgi commented Jun 2, 2025 •
edited
Loading

Description

TL;DR
https://0xpolygon.slack.com/archives/C03PD53G8L9/p1748858685398169

Before:

INFO "✅ Committing new span"                id=1                startBlock=256 endBlock=1855 validatorBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a producerBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a

INFO "✅ Committing new span"                id=1                startBlock=256 endBlock=1855 validatorBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a producerBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a
ERROR message execution failed on contract     err="execution reverted"

After:

INFO  "✅ Committing new span"                id=1                startBlock=256 endBlock=1855 validatorBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a producerBytes=dad9018227109459425e069c8143bf456506d670c900a713bd836a

INFO Skipping the last sprint commit for 0th span spanID=0 headerNumber=240

@kamuikatsurgi kamuikatsurgi merged commit 37d853f into develop Jun 2, 2025
8 of 10 checks passed
@kamuikatsurgi kamuikatsurgi deleted the krishang/dup-span-commit-fix branch June 2, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manav2401 manav2401 manav2401 approved these changes

+1 more reviewer

@avalkov avalkov avalkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamuikatsurgi @avalkov @manav2401