Skip to content

consensus/bor: allow early block announcements#1545

Merged
manav2401 merged 21 commits intoupstream_merge_v1.15.11from
manav/rfc-255
Jun 2, 2025
Merged

consensus/bor: allow early block announcements#1545
manav2401 merged 21 commits intoupstream_merge_v1.15.11from
manav/rfc-255

Conversation

@manav2401
Copy link
Copy Markdown
Member

@manav2401 manav2401 commented May 15, 2025

Description

This PR enables PIP-66. It allows primary block producers to announce blocks early before the header time for optimal time utilisation and preventing reorgs and p2p delays.

Checklist before merging

  • Address comments in Prepare and Verify headers
  • Add unit + integration tests (+fix existing tests if possible)
  • Add check for bhilai HF

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 changed the base branch from upstream_merge_v1.15.7 to upstream_merge_v1.15.11 May 27, 2025 07:55
@cffls
Copy link
Copy Markdown
Contributor

cffls commented May 27, 2025

A few tests have failed. Not sure if it is from the base branch though.

@manav2401
Copy link
Copy Markdown
Member Author

manav2401 commented May 29, 2025

A few tests have failed. Not sure if it is from the base branch though.

My bad. I made the error verbose thinking the tests will also handle it but the tests were matching with the string earlier and hence they failed. Fixed them.

@manav2401 manav2401 merged commit 5f69642 into upstream_merge_v1.15.11 Jun 2, 2025
4 of 7 checks passed
@manav2401 manav2401 deleted the manav/rfc-255 branch June 2, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants