consensus/bor: allow early block announcements#1545
Merged
manav2401 merged 21 commits intoupstream_merge_v1.15.11from Jun 2, 2025
Merged
consensus/bor: allow early block announcements#1545manav2401 merged 21 commits intoupstream_merge_v1.15.11from
manav2401 merged 21 commits intoupstream_merge_v1.15.11from
Conversation
manav2401
commented
May 15, 2025
manav2401
commented
May 15, 2025
lucca30
reviewed
May 23, 2025
lucca30
approved these changes
May 23, 2025
marcello33
approved these changes
May 26, 2025
pratikspatil024
approved these changes
May 27, 2025
Contributor
|
A few tests have failed. Not sure if it is from the base branch though. |
Member
Author
My bad. I made the error verbose thinking the tests will also handle it but the tests were matching with the string earlier and hence they failed. Fixed them. |
…work/bor into manav/rfc-255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables PIP-66. It allows primary block producers to announce blocks early before the header time for optimal time utilisation and preventing reorgs and p2p delays.
Checklist before merging
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it