Skip to content

Heimdallv2 fast consensus#1480

Merged
marcello33 merged 13 commits intoheimdall-v2from
heimdallv2_fast_consensus
Mar 6, 2025
Merged

Heimdallv2 fast consensus#1480
marcello33 merged 13 commits intoheimdall-v2from
heimdallv2_fast_consensus

Conversation

@marcello33
Copy link
Copy Markdown
Collaborator

@marcello33 marcello33 commented Mar 5, 2025 •
edited
Loading

Description

This PR merged the heimdall-v2 fast consensus implementation into heimdall-v2 default branch, based on VEs milestones.
Since that PR is getting merged, having this one will give us one single branch for heimdall-v2/bor

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

cffls and others added 10 commits February 12, 2025 10:47
@maoueh
Copy link
Copy Markdown
Contributor

maoueh commented Mar 5, 2025

Where can we read more about this fast finality in regard, especially for bor client node perspective? Is it going to be reflected within Geth client FinalizedBlock method?

Is this going to be an optimistic finality (e.g. that Heimdall would tell which block is now final to bor) or it will be a deterministic finality (e.g. based on the block's own data, you will be able to determine which block is final relative to a current block)?

Sorry to hijacking a PR, this is important to us and we would like to gathering the overall knowledge sooner than later.

@marcello33 marcello33 requested review from avalkov and cffls March 5, 2025 14:42
@marcello33
Copy link
Copy Markdown
Collaborator Author

marcello33 commented Mar 5, 2025 •
edited
Loading

@avalkov @cffls can I merge this PR to have only one branch for bor compatibility with heimdall-v2?
I only resolved the conflicts and made small changes to have e2e tests running in the CI.
Thanks

@marcello33
Copy link
Copy Markdown
Collaborator Author

marcello33 commented Mar 5, 2025

Hey @maoueh we're still not ready to release any doc about it, but will do it soon.

@marcello33 marcello33 merged commit c548206 into heimdall-v2 Mar 6, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cffls cffls Awaiting requested review from cffls

1 more reviewer

@avalkov avalkov avalkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcello33 @maoueh @avalkov @cffls