rig-surrealdb: support dynamic_context #1646
Merged
gold-silver-copper merged 1 commit into0xPlaygrounds:mainfrom Apr 17, 2026
Merged
rig-surrealdb: support dynamic_context #1646gold-silver-copper merged 1 commit into0xPlaygrounds:mainfrom
gold-silver-copper merged 1 commit into0xPlaygrounds:mainfrom
Conversation
1 task
Merged
This was referenced Apr 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1644.
Summary
dynamic_context(...)currently does not work withrig-surrealdbbecause the blanketVectorStoreIndexDynimpl inrig-coreassumes backends whose filter value type isserde_json::Value, whileSurrealSearchFilterintentionally uses nativesurrealdb::types::Value.This PR fixes that incompatibility without changing the public SurrealDB filter API.
What changed
SurrealSearchFilter::Value = surrealdb::types::ValueTryFrom<Filter<serde_json::Value>> for SurrealSearchFilterVectorStoreIndexDynimpl forSurrealVectorStorethat converts canonical JSON filters with
try_map_filter(SurrealSearchFilter::try_from)before delegating to the native
VectorStoreIndeximplementationValue::from_t(...)conversion path instead of a custom JSON-to-Value mapperSurrealVectorStorevector_storeexample with explicit top-hit assertionsrig-core/rustls, since they call OpenAIManually ran:
cargo run -p rig-surrealdb --example vector_store --features rig-core/rustlsThe updated example now returns
pasta carbonaraas the expected top hit andasserts that the thresholded query narrows to that single result.