Migrate to Miden VM v0.22.0 and Miden Crypto v0.23.0#2644
Conversation
|
Should we remove references to |
Ah, they're still there, but since we migrated to the poseidon2 already, I think they could be safely removed (AFAIK the words order was already reversed) |
85ceb16 to
dd4efd1
Compare
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
| # ================================================================================================= | ||
|
|
||
| type EthereumAddressFormat = struct @bigendian { a: felt, b: felt, c: felt, d: felt, e: felt } | ||
| type EthereumAddressFormat = struct { a: felt, b: felt, c: felt, d: felt, e: felt } |
There was a problem hiding this comment.
I think this was recently renamed - not sure if the renaming is applicable here though. cc @partylikeits1983.
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of comments inline - both should be pretty easy to address.
| # use $kernel::type_aliases::AccountID | ||
| use miden::core::mem | ||
| # use miden::standards::type_aliases::AccountID | ||
|
|
||
| pub type AccountID = struct { prefix: felt, suffix: felt } |
There was a problem hiding this comment.
For some reason I still can't use the imported types in the protocol lib (here and in the api.masm). Attempt to do so results in an error during the compilation:
Warning: ! unused import
,-[/Users/fumuran/Desktop/Miden/miden-base/target/debug/build/miden-protocol-ee74c6f9e81b4cd4/out/asm/kernels/transaction/api.masm:10:5]
9 | use $kernel::tx
10 | use $kernel::type_aliases::AccountID
: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
11 |
`----
help: this import is never used and can be safely removed
while this import is clearly used (it returns undefined symbol reference on the used type if I remove the import). Interestingly this unused import error is raised even if the module is clearly doesn't exist, something like use $kernel::qwerty:type_aliases::AccountID. I'm not sure that this is a correct behavior, I would expect the undefined symbol reference to be raised. Could it be a bug?
There was a problem hiding this comment.
Is it only for importing from the $kernel namespace? If you can get a minimal reproducible example of this, would be good to file a bug in miden-vm.
There was a problem hiding this comment.
@bitwalker, @plafer could you guys please take a look? Is this an incorrect behavior, or I did something wrong?
Edit: sorry, didn't see Bobbin's response when was asking. I suppose it will be better for me to prepare an example first.
There was a problem hiding this comment.
Created an issue: https://github.com/0xMiden/protocol/issues/2656
|
I would merge this PR just to unblock the release pipeline, but I'll create an issue and a minimal example for addressing this bug in a following PR. |
This PR updates the code to use the Miden VM of version
v0.22.0and Miden Cryptov0.23.0.No breaking changes since previous
v0.22.0-alpha.1update.