Conversation
partylikeits1983
approved these changes
Mar 17, 2026
Member
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks good.
Its almost like we need some sort of procedure modifier onlyFPI, which would only allow a procedure to be called via FPI.
67b23e9 to
5bbf5d3
Compare
Collaborator
Author
|
Actually after re-orienting the |
verify_leaf_bridgeverify_leaf_bridge is no longer part of the bridge interface
partylikeits1983
approved these changes
Mar 17, 2026
Comment on lines
-184
to
+271
| #! Invocation: call | ||
| @locals(8) # leaf value | ||
| pub proc verify_leaf_bridge | ||
| #! Invocation: exec | ||
| proc verify_leaf_bridge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that all
execinvocations actually use the_innervariant, and thecallinvocations use the public facing procedure.EDIT: see #2612 (comment)