Merged
Conversation
- Update baseline to "to-be-tagged v0.14-alpha" - Add explanation for why native claim amount is verified (avoids expensive U256 division inside the VM) - Simplify addr output notation to addr(5) https://claude.ai/code/session_01UDgsAS2j2CFrTLsDoLiSUN
cf11698 to
c13d605
Compare
…2513) * docs: add Section 5 — Ethereum ↔ Miden address conversion spec Comprehensive specification of the address conversion encoding between Ethereum 20-byte addresses and Miden AccountId (two field elements), covering the embedded format, MASM limb representation, Rust and MASM conversion procedures, endianness details, and roundtrip guarantees. Addresses #2229 https://claude.ai/code/session_01YabAhXZeStAkKkYwBcXXFh * Apply suggestions from code review Update crates/miden-agglayer/SPEC.md Update crates/miden-agglayer/SPEC.md Update crates/miden-agglayer/SPEC.md * fix: EthAddressFormat::from_account_id usage * docs: clean up address conversion --------- Co-authored-by: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an implementation-oriented specification document for the miden-agglayer bridge integration, and updates MASM documentation to clarify address limb endianness.
Changes:
- Introduces
crates/miden-agglayer/SPEC.mddescribing contracts, note flows, storage layouts, and Ethereum↔Miden address encoding. - Clarifies
build_feltendianness semantics ineth_address.masmdoc comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/miden-agglayer/asm/agglayer/common/eth_address.masm | Doc comment tweak to clarify limb/byte endianness for felt packing. |
| crates/miden-agglayer/SPEC.md | New, detailed bridge integration specification covering interfaces, note types, and encoding semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
merging for now, we can revisit the docs in details during the internal audit, or as we go along |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.