Skip to content

chore: use standard faucet metadata name for faucet components#2161

Merged
PhilippGackstatter merged 24 commits intonextfrom
pgackst-find-slot
Dec 12, 2025
Merged

chore: use standard faucet metadata name for faucet components#2161
PhilippGackstatter merged 24 commits intonextfrom
pgackst-find-slot

Conversation

@PhilippGackstatter
Copy link
Copy Markdown
Contributor

@PhilippGackstatter PhilippGackstatter commented Dec 11, 2025 •
edited
Loading

  • Standardizes basic/network fungible faucet slot name to miden::standards::fungible_faucets::metadata, closes Decide whether to refactor verify_signatures and standard faucets #2135.
  • Small renames of functions/procedures for consistency.
  • Adds a test test_account_get_item_fails_on_unknown_slot to ensure get_item returns "unknown storage slot" error in accounts with empty or non-empty storage.
  • Re-adds a test to ensure writing to the reserved faucet metadata slot fails.

part of #1724

@PhilippGackstatter PhilippGackstatter marked this pull request as draft December 11, 2025 04:32
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review December 11, 2025 05:07
@PhilippGackstatter PhilippGackstatter linked an issue Dec 11, 2025 that may be closed by this pull request
Decide whether to refactor verify_signatures and standard faucets #2135
Closed
mmagician
mmagician reviewed Dec 11, 2025
View reviewed changes
bobbinth
bobbinth approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left two optional comments inline.

Base automatically changed from pgackst-sorted-named-slots to next December 12, 2025 02:01
@PhilippGackstatter PhilippGackstatter merged commit 5433d1f into next Dec 12, 2025
17 checks passed
@PhilippGackstatter PhilippGackstatter deleted the pgackst-find-slot branch December 12, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbinth bobbinth bobbinth approved these changes

@mmagician mmagician Awaiting requested review from mmagician

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decide whether to refactor verify_signatures and standard faucets

3 participants

@PhilippGackstatter @mmagician @bobbinth