fix: incorrect detection of note inputs length during note creation#2066
Merged
fix: incorrect detection of note inputs length during note creation#2066
Conversation
bobbinth
approved these changes
Nov 6, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just a couple of small comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect detection of note inputs length during note creation. See the issue for details.
This targets
mainand does not contain breaking changes on the API level.Also fixes changelog date format to be consistent with previous entries (ISO8601 format)
addresses #2065
I guess we want to keep that issue (or one of the two related ones open for a better fix).