feat: re-export struct required to create Package#1984
Merged
bobbinth merged 7 commits into0xMiden:nextfrom Oct 16, 2025
Merged
feat: re-export struct required to create Package#1984bobbinth merged 7 commits into0xMiden:nextfrom
bobbinth merged 7 commits into0xMiden:nextfrom
Conversation
…teSet, QualifiedProcedureName Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Contributor
|
@lima-limon-inc - could you add a changelog entry and also fix the lints? |
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Contributor
Author
Sure thing! I addressed these comments in this commit 7bbafd8 and this other commit 2a59aad respectively. As a sidenote: I think some of the previous |
igamigo
approved these changes
Oct 14, 2025
CHANGELOG.md
Outdated
| - Added `StorageMap::{num_entries, num_leaves}` to retrieve the number of entries in a storage map ([#1935]https://github.com/0xMiden/miden-base/pull/1935). | ||
| - Added `AssetVault::{num_assets, num_leaves, inner_nodes}` ([#1939]https://github.com/0xMiden/miden-base/pull/1939). | ||
| - Implemented `input_note::get_sender` and `active_note::get_metadata` procedures in `miden` lib ([#1933](https://github.com/0xMiden/miden-base/pull/1933)). | ||
| - Added `Address` serialization and deserialization ([#1937](https://github.com/0xMiden/miden-base/issues/1937)) |
Collaborator
There was a problem hiding this comment.
nit: ending period removed
Contributor
Author
There was a problem hiding this comment.
nit: ending period removed
My bad, updated in this commit: 0dbda0e
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
bobbinth
approved these changes
Oct 16, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you. I left one comment inline - once it is addressed, let's merge.
bobbinth
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by this PR 0xMiden/miden-client#1313
In order to create a
Packageto create anAccountComponet, themiden-clientneeds to access the following structures which are not yet re-exported:MastArtifact,PackageExport,PackageManifestAttributeSet,QualifiedProcedureName