-
Notifications
You must be signed in to change notification settings - Fork 124
Labels
good first issueGood for newcomersGood for newcomersstandardsRelated to standard note scripts or account componentsRelated to standard note scripts or account components
Milestone
Description
After #2364, we have these constants defined in four places in miden-standards:
const AUTH_UNAUTHORIZED_EVENT = event("miden::protocol::auth::unauthorized")
const AUTH_REQUEST_EVENT = event("miden::protocol::auth::request")
Since we can now make constants public, we should define these in miden::protocol::auth.
To do this we can:
- Add a new module
crates/miden-protocol/asm/protocol/auth.masm. - Define these constants as
pub const. - Replace the four occurrences in
miden::standards(e.g. incrates/miden-standards/asm/account_components/auth/ecdsa_k256_keccak_multisig.masm) with imports of the constants. - And remove the custom handling of these events in
build.rs:
https://github.com/0xMiden/miden-base/blob/72f5fc670b9d6b8492c18c703c81127416e81dff/crates/miden-protocol/build.rs#L426-L429
Context: #2364 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersstandardsRelated to standard note scripts or account componentsRelated to standard note scripts or account components