-
Notifications
You must be signed in to change notification settings - Fork 124
Include Full output notes in ExecutedTransaction #1049
Description
Feature description
We are currently working on Miden Playground, and we have a requirement to display output notes after executing a transaction. At present, when we use the TransactionExecutor from the miden_tx crate to execute a transaction with a SWAP note using the execute_transaction function, I find that there is a Partial Payback note in the output_notes of the ExecutedTransaction.
It would be preferable to have a Full output note in the output_notes of the ExecutedTransaction instead, as the Miden Playground needs to show complete information about each note.
I have observed that in the Miden client, we construct an expected future payback note before executing a transaction. However, I believe this approach may not be suitable for Miden Playground. Users can modify notes (script, inputs, and assets), and as a result, we cannot definitively determine if a note remains a SWAP or becomes something else after user edits. Ideally, in our case we should build the payback output note after the transaction execution.
Could we explore implementing this improvement?
Why is this feature needed?
No response