Merged
Conversation
f9e2971 to
7dd4d33
Compare
fkrause98
reviewed
Dec 22, 2025
fkrause98
reviewed
Dec 22, 2025
SantiagoPittella
approved these changes
Dec 22, 2025
fkrause98
reviewed
Dec 22, 2025
Comment on lines
38
to
39
| /// Returns the value for a key in the map stored at the given slot, if any. | ||
| #[wasm_bindgen(js_name = "getMapItem")] |
Contributor
There was a problem hiding this comment.
Maybe we can update this comment stating where the user can find a list of slot names?
fkrause98
reviewed
Dec 22, 2025
fkrause98
reviewed
Dec 22, 2025
fkrause98
approved these changes
Dec 22, 2025
juan518munoz
approved these changes
Dec 22, 2025
Collaborator
juan518munoz
left a comment
There was a problem hiding this comment.
Besides what the others have commented, PR looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates to new
miden-base.Notable changes:
FilesystemKeystore's generic