Closed
Conversation
This commit updates the `v2::Receiver` to be generic over its typestate (e.g., `UncheckedProposal`, `InputsSeen`, etc.). The motivation: * Improves readability and maintainability: Each typestate now clearly belongs to the receiver session. This makes the code easier to reason about, without runtime cost. It also sets us up to define a shared pattern between v2, NS1R and future state machines. * Decouples typestate data from transition logic: NS1R typesates can now consume state structs without being tied to the transition machinery. This keeps state transitions encapsulated and makes the underlying session data easier to use in other contexts. This commit renames the original `Receiver` struct to `WithContext`. This type now represents the receiver session once the HPKE context has been created. The Receiver name is re-purposed for the new generic wrapper over typestate. For the UniFFI exported receiver we monomorphizes the exported structs over a specific typestate. UniFFI doesn't support exporting generic structs, so we expose a concrete type to the FFI.
The full paths are often hard to read and create noise in this file.
Pull Request Test Coverage Report for Build 15351526536Details
💛 - Coveralls |
922a224 to
1b42be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.