Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements kernel zero-copy optimization for TCP streams across the HTTP and SOCKS modules to improve performance. The changes centralize the zero-copy logic and apply it consistently throughout the codebase.
- Centralizes zero-copy logic in a new
iomodule with platform-specific implementations - Updates HTTP module to use zero-copy for non-TLS connections while maintaining standard copy for TLS
- Replaces inline platform-specific code in SOCKS module with centralized implementation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/io.rs | New module providing centralized zero-copy implementation with Linux/non-Linux fallback |
| src/main.rs | Adds the new io module to the crate structure |
| src/server/http/mod.rs | Updates HTTP handler to use zero-copy for non-TLS connections and adds TLS parameter threading |
| src/server/socks/mod.rs | Replaces inline zero-copy logic with centralized implementation |
| src/server/auto.rs | Updates type annotations to match new HTTP acceptor generic parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.