[deps] Move "semver" to devDependencies#2595
Merged
ljharb merged 1 commit intojsx-eslint:masterfrom Mar 17, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semveris listed independencies, but only seems to be used in this test and not in the plugin itself:https://github.com/yannickcr/eslint-plugin-react/blob/e231f44c38d28878039edeb43e009b153614ca0a/tests/lib/rules/no-unescaped-entities.js#L12
This PR moves it to
devDependenciesso that downstream projects don't have to include an unnecessary dependency.