Fix windows directory separator#687
Merged
sindresorhus merged 4 commits intoxojs:mainfrom Aug 31, 2022
skarab42:fix-window-directory-separator
Merged
Fix windows directory separator#687sindresorhus merged 4 commits intoxojs:mainfrom skarab42:fix-window-directory-separator
sindresorhus merged 4 commits intoxojs:mainfrom
skarab42:fix-window-directory-separator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sindresorhus Under windows some tests on file names did not match because they were compared with different directory separators. This PR fixes this issue using the
slashlib where it was required for my case, it is possible that for other configurations (under windows) it should be done elsewhere as well.Fixes sindresorhus/type-fest#451