fix: tsconfig resolution quirks#683
Merged
sindresorhus merged 1 commit intoxojs:mainfrom Aug 26, 2022
Merged
Conversation
spence-s
commented
Aug 26, 2022
| basePath = require.resolve(path.join(tsConfig.extends, 'tsconfig.json')); | ||
| } catch { | ||
| // Throw the orginal resolution error to let the user know their extends block is invalid | ||
| throw error; |
Contributor
Author
There was a problem hiding this comment.
alternatively we could just swallow this error, and when that happens we would just generate the needed tsconfig for the file. That may be the better way to handle this.
Member
There was a problem hiding this comment.
I don't think we should swallow errors like that. It sounds like a pain to debug that it's working, but with the incorrect config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #682
extendsUnfortunately tsconfig resolution is less straightforward that I thought, and apologies for the churn around this. Hopefully this change will now support the vast majority of ways people can use a tsconfig
I have played around with using TS directly for parsing the tsconfig it works, but the downsides are that it breaks a lot of tests, is a relatively big refactoring, and it is all sync methods.