Skip to content

More sentence case fixes for labels, etc.#19377

Merged
mkaz merged 5 commits intomasterfrom
update/more-sentence-case-fixes
Jan 4, 2020
Merged

More sentence case fixes for labels, etc.#19377
mkaz merged 5 commits intomasterfrom
update/more-sentence-case-fixes

Conversation

@mapk
Copy link
Copy Markdown
Contributor

@mapk mapk commented Dec 31, 2019

Description

This PR fixes more labels and copy to conform to Sentence case.

How has this been tested?

Tested locally.

Types of changes

Non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mapk mapk added General Interface Parts of the UI which don't fall neatly under other labels. [Type] Copy Issues or PRs that need copy editing assistance labels Dec 31, 2019
@mapk mapk requested a review from talldan as a code owner December 31, 2019 22:16
@mapk mapk self-assigned this Dec 31, 2019
mkaz
mkaz requested changes Jan 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. However, you'll need to update the tests to match the updated text. If you look at the details link from the Travis CI and click through each failing test it will show you each test and where it is failing.

@mapk mapk requested review from ajitbohra, nerrad and ntwb as code owners January 2, 2020 23:13
@mapk mapk requested a review from gziolo as a code owner January 3, 2020 00:43
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Jan 3, 2020

For reference, there is one failing unit test:
https://travis-ci.com/WordPress/gutenberg/jobs/271982464#L393
it has a corresponding snapshot saved which can be updated manually.

There are also 3 failing e2e tests for meta boxes:
https://travis-ci.com/WordPress/gutenberg/jobs/271982469#L792

It's quite possible that View Post is passed from PHP as this is something that depends on the post type.

@mapk mapk requested a review from mkaz January 3, 2020 23:49
mkaz
mkaz approved these changes Jan 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@mkaz mkaz merged commit 7a0e48c into master Jan 4, 2020
@mkaz mkaz deleted the update/more-sentence-case-fixes branch January 4, 2020 18:41
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkaz mkaz mkaz approved these changes

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@mapk mapk

Labels

General Interface Parts of the UI which don't fall neatly under other labels. [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Milestone

Gutenberg 7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@mapk @gziolo @mkaz @youknowriad @aduth