Skip to content

Removed the bottom-margin for the radio-control#19340

Merged
mkaz merged 1 commit intomasterfrom
update/radio-control-bottom-margin
Dec 29, 2019
Merged

Removed the bottom-margin for the radio-control#19340
mkaz merged 1 commit intomasterfrom
update/radio-control-bottom-margin

Conversation

@mapk
Copy link
Copy Markdown
Contributor

@mapk mapk commented Dec 27, 2019

Description

Fixes #17929.
There was an extra bottom-margin on the radio-control as indicated in #17929. I edited the radio-control to remove this margin.

How has this been tested?

Tested locally. I checked through some settings, although the Latest Posts block may be the only block settings that utilize this particular combination of cascaded styles.

Screenshots

radio-control 2019-12-26 22_06_53

Types of changes

Non-breaking CSS changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mapk mapk self-assigned this Dec 27, 2019
@mapk mapk added Needs Testing Needs further testing to be confirmed. [Feature] Inspector Controls The interface showing block settings and the controls available for each block labels Dec 27, 2019
Copy link
Copy Markdown
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fix, looks good 👍

@mkaz mkaz merged commit 1c14c2a into master Dec 29, 2019
@mkaz mkaz deleted the update/radio-control-bottom-margin branch December 29, 2019 14:50
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Inspector Controls The interface showing block settings and the controls available for each block Needs Testing Needs further testing to be confirmed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Radio Control spacing inconsistency

3 participants