Merged
Conversation
Member
|
Makes sense to me. 👍 |
Contributor
|
The smaller button looks a little strange, visually, but I agree the wide button is way too prominent. I'd be in favor of trying a link style for this — but happy to have that be a separate PR. Along with that, it'd be really nice to add a confirmation to this action. |
Member
Author
|
Ok based on feelings, let's try a smaller button then we can try a PR for a link if people think it's too weird. I would also be happy to try a link. Thanks, everyone. |
Contributor
|
I'd second revisiting as a link. It's not a primary or even secondary action. I don't see a need to draw more attention to it than necessary and a link feels about right in the visual hierarchy. |
Member
Author
|
@MichaelArestad it's now merged as a link #19138 |
Contributor
|
Oh heck yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trash button right now is full width, which is not a pattern used a lot elsewhere. It also encourages you to move to trash almost as so large.
A little fix to this could be to explore just making it a normal button here:
I would argue making it just a text link could also work, but let's see what feedback is about the button for now.