Skip to content

Adding keyword 'download' to the file block for easier searching.#18995

Merged
mapk merged 3 commits intomasterfrom
add/file-block-keyword
Dec 9, 2019
Merged

Adding keyword 'download' to the file block for easier searching.#18995
mapk merged 3 commits intomasterfrom
add/file-block-keyword

Conversation

@mapk
Copy link
Copy Markdown
Contributor

@mapk mapk commented Dec 7, 2019

Description

Added a new keyword to the File block for easier searching: download.

How has this been tested?

Tested locally.

Screenshots

Screen Shot 2019-12-07 at 10 04 01 AM

Types of changes

Non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mapk mapk added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Block] File Affects the File Block labels Dec 7, 2019
@mapk mapk self-assigned this Dec 7, 2019
@melchoyce
Copy link
Copy Markdown
Contributor

melchoyce commented Dec 7, 2019

Is it okay that package-lock.json changed too?

@aduth
Copy link
Copy Markdown
Member

aduth commented Dec 8, 2019

Is it okay that package-lock.json changed too?

It doesn't seem to me that it should be expected to be updated here.

@karmatosed
Copy link
Copy Markdown
Member

karmatosed commented Dec 9, 2019

Yes, the .json file isn't needed and likely came from doing an npm install audit fix, or something localhost side. @mapk can you push a PR without that file, please?

@mapk
Copy link
Copy Markdown
Contributor Author

mapk commented Dec 9, 2019

Oh danggit, @melchoyce. I think you're right. Let me see if I can fix that.

@mapk
Copy link
Copy Markdown
Contributor Author

mapk commented Dec 9, 2019

Thanks, @aduth for figuring out how to reset the package-lock.json file again. I appreciate the insight! 👍

@mapk mapk merged commit 2f64cb5 into master Dec 9, 2019
@mapk mapk deleted the add/file-block-keyword branch December 9, 2019 17:07
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@mapk mapk

Labels

[Block] File Affects the File Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@mapk @melchoyce @aduth @karmatosed @youknowriad