Update the copy of the Experiments page by Copons · Pull Request #18233 · WordPress/gutenberg

Copons · 2019-11-01T11:06:19Z

Description

Update the copy and fix the capitalization of the Experiments page.
Also adds a note to the Full Site Editing experiment, warning that it's still a WIP feature and could potentially break the site.

Testing instructions

Open /wp-admin/admin.php?page=gutenberg-experiments and make sure it looks fine.

vindl · 2019-11-05T15:42:34Z

lib/experiments-page.php

 		'gutenberg_experiments_section',
 		array(
-			'label' => __( 'Enable Full Site Editing', 'gutenberg' ),
+			'label' => __( 'Enable Full Site Editing (Warning: this will break the site)', 'gutenberg' ),


Another option would be to mark it as (Unstable), and then clarify below what it actually means. :)

Imho "unstable" doesn't sound dangerous enough 😄

Seems like the warning is now hard to miss. Looks like a good change.

and then clarify below what it actually means.

Perhaps it is worth considering clarifying below what "break the site" means, but I think the warning gets the main point across.

Addison-Stavlo

Il approve for what it's worth. It definitely seems like a good fix to make that warning a bit more apparent while FSE is being developed. It does look like we still have reviews requested from others though.

talldan · 2019-12-03T07:04:58Z

I see the need for an additional warning, but the current text does seem extreme. I agree that it might be worth elaborating some more on what happens (e.g. 'Warning: this will replace your theme and cause potentially irreversible changes to your site. Please consider using this only in a development environment.')

This has been happening rather frequently on WordPress.com, which threw off track our customer support people that weren't aware of the Full Site Editing experiment.

Maybe WordPress.com needs some more control over whether the experiments are visible or be able to override specific experiments to be disabled using a filter or something similar.

Copons · 2019-12-03T09:51:04Z

@talldan Yup, the copy here was intended as a placeholder to get the discussion going.
I promised to involve some copy review once we decided this was the way to go.
I'll update this with your suggestion and then add the Needs Copy Review label. 👍

Maybe WordPress.com needs some more control over whether the experiments are visible or be able to override specific experiments to be disabled using a filter or something similar.

There are some specific cases in which we might want to leave the experiments available to users.
Normally they are not as disruptive, but the FSE one completely replaces the front end with the (in progress) FSE templates, without any clear indications of what happened.

michelleweber · 2019-12-13T13:31:26Z

I like @talldan's wording, and have minor suggestions for that whole area -- some capitalization fixes, some rephrasing.

Experimental settings

The block editor includes experimental features that are useable while they're in development. Select the ones you'd like to enable. These features are likely to change, so avoid using them in production.

Enable Widgets screen and Legacy Widgets block

Enable Navigation Menu block

Enable block directory search

Enable Full Site Editing (Note: Warning: this will replace your theme and cause potentially irreversible changes to your site. We recommend using this only in a development environment.)

Copons · 2019-12-13T14:44:08Z

@michelleweber Thanks for the suggestions!
Though it seems you've based them upon the old screenshots I provided in the PR description.

Currently, the Experiment page is like this:

It's not completely different, but a couple of experiments changed.

I can incorporate your suggestions in this PR, so I'm just double checking in case you wish to improve the copy of the new experiments too. 🙂

michelleweber · 2019-12-16T09:47:26Z

Ah, gotcha! Yes, there are some small changes, just to capitalization, that we should make in the current copy:

Enable Widgets screen and Legacy Widgets block
Enable block directory search
Enable Full Site Editing (Note: Warning: this will replace your theme and cause potentially irreversible changes to your site. We recommend using this only in a development environment.)
Enable Full Site Editing demo templates
Enable page templates

Copons · 2019-12-16T11:41:49Z

Thanks @michelleweber! I've updated the strings as per your suggestions and removed the Needs Copy Review label. 🙇

talldan

This looks good, thanks @Copons and @michelleweber!

carlomanf · 2020-05-27T01:58:35Z

Hi, don't know if this is the right place to ask, but can someone clarify what "potentially irreversible changes" these are referring to?

From what I can tell, everything is reverted back when the FSE is turned off?

Copons added [Type] Question Questions about the design or development of the editor. [Feature] Full Site Editing labels Nov 1, 2019

Copons requested a review from felixarntz November 1, 2019 11:06

Copons requested a review from TimothyBJacobs as a code owner November 1, 2019 11:06

Copons self-assigned this Nov 1, 2019

vindl reviewed Nov 5, 2019

View reviewed changes

Addison-Stavlo approved these changes Nov 12, 2019

View reviewed changes

vindl approved these changes Nov 15, 2019

View reviewed changes

Copons force-pushed the update/full-site-editing-experiment-warning branch from 31edab4 to ccb3018 Compare December 13, 2019 13:12

Copons added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 13, 2019

Copons and others added 3 commits December 16, 2019 11:34

Add an additional warning for the FSE experiment setting

2cb5ebf

Updated warning text

c2cd062

Update the copy some more

6b0c8f6

Copons force-pushed the update/full-site-editing-experiment-warning branch from 248a4ea to 6b0c8f6 Compare December 16, 2019 11:38

Copons changed the title ~~Add an additional warning for the Full Site Editing experiment setting~~ Update the copy of the Experiments page Dec 16, 2019

Copons removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 16, 2019

Copons requested a review from vindl December 16, 2019 11:41

talldan approved these changes Dec 17, 2019

View reviewed changes

talldan merged commit 2cb7828 into master Dec 17, 2019

talldan deleted the update/full-site-editing-experiment-warning branch December 17, 2019 05:56

youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020

naiba4 mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 naiba4/gutenberg#52

Open

MaxMood96 mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 MaxMood96/gutenberg#151

Open

jay-Anonymous mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 jay-Anonymous/gutenberg#8

Open

monzerfoda mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 4.19.1 to 9.0.0 monzerfoda/gutenberg#23

Open

soloinovator mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 soloinovator/gutenberg#137

Open

yassine4999 mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 yassine4999/gutenberg#41

Open

petrescugit mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 petrescugit/gutenberg#19

Open

yaseenaljamal mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 yaseenaljamal/gutenberg#20

Open

makbarGroup mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 4.19.1 to 9.0.0 makbarGroup/gutenberg#59

Open

This was referenced Apr 6, 2024

[Snyk] Security upgrade eslint from 7.32.0 to 9.0.0 Verdinjoshua26/gutenberg#114

Open

[Snyk] Fix for 2 vulnerabilities Verdinjoshua26/gutenberg#115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the copy of the Experiments page#18233

Update the copy of the Experiments page#18233
talldan merged 3 commits intomasterfrom
update/full-site-editing-experiment-warning

Copons commented Nov 1, 2019 •

edited

Loading

Uh oh!

vindl Nov 5, 2019

Uh oh!

Copons Nov 5, 2019

Uh oh!

Addison-Stavlo Nov 8, 2019

Uh oh!

Addison-Stavlo left a comment

Uh oh!

talldan commented Dec 3, 2019

Uh oh!

Copons commented Dec 3, 2019 •

edited

Loading

Uh oh!

michelleweber commented Dec 13, 2019 •

edited

Loading

Uh oh!

Copons commented Dec 13, 2019

Uh oh!

michelleweber commented Dec 16, 2019

Uh oh!

Copons commented Dec 16, 2019

Uh oh!

talldan left a comment

Uh oh!

carlomanf commented May 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Copons commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

vindl Nov 5, 2019

Choose a reason for hiding this comment

Uh oh!

Copons Nov 5, 2019

Choose a reason for hiding this comment

Uh oh!

Addison-Stavlo Nov 8, 2019

Choose a reason for hiding this comment

Uh oh!

Addison-Stavlo left a comment

Choose a reason for hiding this comment

Uh oh!

talldan commented Dec 3, 2019

Uh oh!

Copons commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michelleweber commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copons commented Dec 13, 2019

Uh oh!

michelleweber commented Dec 16, 2019

Uh oh!

Copons commented Dec 16, 2019

Uh oh!

talldan left a comment

Choose a reason for hiding this comment

Uh oh!

carlomanf commented May 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Copons commented Nov 1, 2019 •

edited

Loading

Copons commented Dec 3, 2019 •

edited

Loading

michelleweber commented Dec 13, 2019 •

edited

Loading