Disable running session.install outside a venv#580
Merged
DiddiLeija merged 4 commits intowntrblm:mainfrom Mar 1, 2022
Merged
Conversation
Collaborator
Author
|
Of course, this will fail for now (the tests will break!) but I'll fix that soon. |
Collaborator
Author
|
Oh no, the linters also failed :/ |
DiddiLeija
commented
Feb 24, 2022
Collaborator
Author
DiddiLeija
left a comment
There was a problem hiding this comment.
Ok, a few questions below. Also, other suggestions are accepted.
session.install outside a venvsession.install outside a venv
Collaborator
Author
|
Ok, I think this PR is ready now. I just want to know your opinion about my questions above :) |
cjolowicz
approved these changes
Mar 1, 2022
Collaborator
Author
|
Merging then. Thanks @cjolowicz for adding your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #503 (comment) and #537 (comment). Closes #541.
This PR finishes the work of removing the option of running
session.installoutside a venv, which is possible because we already had a deprecation phase since2022.1.7(see #537).Sorry if I delayed a lot for pushing this, I created the branch a while ago but had several conflicts, and had to restart all the work again 😞 1.
TODO:
session.installoutside a venvUpdateReplace the test from Deprecate use of session.install() without a virtual env #537Footnotes
About the branch name,
no-venv-no-install, I've been thinking about it for a long time. If you've heard or seen the common rule "No shirt, no shoes, no service", you will understand "No venv, no install" 😅 ↩