chore: added await in order to resolve the pending promise#948
Merged
ematipico merged 1 commit intowebpack:masterfrom Jun 16, 2019
anikethsaha:chore/init-generator
Merged
chore: added await in order to resolve the pending promise#948ematipico merged 1 commit intowebpack:masterfrom anikethsaha:chore/init-generator
ematipico merged 1 commit intowebpack:masterfrom
anikethsaha:chore/init-generator
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
anshumanv
reviewed
Jun 13, 2019
Member
anshumanv
left a comment
There was a problem hiding this comment.
Bad rebase? I see a lot of unrelated commits
Contributor
Author
|
yeah, messed up the rebasing. trying to fix it. 👍 PS: Finally done fixing the rebasing. |
wizardofhogwarts
approved these changes
Jun 15, 2019
ematipico
approved these changes
Jun 15, 2019
anshumanv
approved these changes
Jun 15, 2019
evenstensberg
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix/refactoring
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Added
awaitin order to resolve the pending promise which was resulting in prompting error for 3rd question in init commandDoes this PR introduce a breaking change?
NA
Other information
NA