chore(serve): refactor code to be more concise#974
Merged
evenstensberg merged 5 commits intowebpack:masterfrom Jul 6, 2019
Merged
chore(serve): refactor code to be more concise#974evenstensberg merged 5 commits intowebpack:masterfrom
evenstensberg merged 5 commits intowebpack:masterfrom
Conversation
dcfafa8 to
147fc23
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
Jun 27, 2019
Contributor
|
The commit message should be |
4ce52ac to
0d9aa9a
Compare
rishabh3112
approved these changes
Jun 28, 2019
rishabh3112
reviewed
Jun 28, 2019
Member
rishabh3112
left a comment
There was a problem hiding this comment.
Change PR title too as @ematipico said
Member
evenstensberg
left a comment
There was a problem hiding this comment.
Could you add a little comment on the double array inddex accesses?
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
ematipico
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
Refactored the serve action handler to a more concise form.
Does this PR introduce a breaking change?
Nope
Other information
N/A