Skip to content

throw error when using module concatenation and cacheUnaffected#15624

Merged
sokra merged 1 commit into
mainfrom
add-warning-when-cache-unaffected-and-concat-modules
Apr 5, 2022
Merged

throw error when using module concatenation and cacheUnaffected#15624
sokra merged 1 commit into
mainfrom
add-warning-when-cache-unaffected-and-concat-modules

Conversation

@vankop

@vankop vankop commented Apr 4, 2022

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
nothing

What needs to be documented once your changes are merged?
nothing

optimization.concatenateModules can't be used with cacheUnaffected as module concatenation is a global effect
@webpack-bot

Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit cb639b3 into main Apr 5, 2022
@sokra sokra deleted the add-warning-when-cache-unaffected-and-concat-modules branch April 5, 2022 06:02
@sokra

sokra commented Apr 5, 2022

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants