Allow banner to be placed as a footer#15617
Merged
Merged
Conversation
|
|
Contributor
|
For maintainers only:
|
Member
|
Thanks |
Contributor
|
I've created an issue to document this in webpack/webpack.js.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
There is a plugin we are using for version 4 that does the same thing as BannerPlugin, but it could place the text at the bottom of the file instead of the top. This allows the BannerPlugin to place the banner either as a header or footer. No other changes
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No. The new flag defaults to falsy
What needs to be documented once your changes are merged?
The website will need to be updated here to reflect the new optional parameter
footer