Skip to content

Fix duplicate backtrace when using wandb-service#3575

Merged
raubitsj merged 6 commits intomasterfrom
WB-9395
Apr 27, 2022
Merged

Fix duplicate backtrace when using wandb-service#3575
raubitsj merged 6 commits intomasterfrom
WB-9395

Conversation

@kptkin
Copy link
Copy Markdown
Collaborator

@kptkin kptkin commented Apr 26, 2022

Fixes WB-9395

Description

What does the PR do?

This PR remove duplicate backtrace in case where service is enabled when user's scripts raises an exception. This PR guards the hooking of the ExitHook on the fact that service is not enabled.

Testing

How was this PR tested?

Tested as part of this PR:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2022

Codecov Report

Merging #3575 (a11327a) into master (4ad4e84) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
+ Coverage   81.55%   81.57%   +0.02%     
==========================================
  Files         240      240              
  Lines       29478    29478              
==========================================
+ Hits        24041    24047       +6     
+ Misses       5437     5431       -6     
Flag Coverage Δ
functest 57.59% <50.00%> (+0.03%) ⬆️
unittest 71.80% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/lib/exit_hooks.py 94.28% <0.00%> (ø)
wandb/sdk/wandb_run.py 89.84% <100.00%> (ø)
wandb/filesync/step_prepare.py 93.50% <0.00%> (-1.30%) ⬇️
wandb/sdk/lib/git.py 76.19% <0.00%> (ø)
wandb/sdk/lib/sock_client.py 94.16% <0.00%> (+1.66%) ⬆️
wandb/sdk/internal/meta.py 90.68% <0.00%> (+3.10%) ⬆️

@kptkin kptkin modified the milestones: sdk-2022-05.2, sdk-2022-05.1 Apr 26, 2022
@kptkin kptkin changed the title remove duplicate exit hook [WB-9395] Fixes duplicate backtrace when using service Apr 26, 2022
@kptkin kptkin requested review from dmitryduev and raubitsj April 26, 2022 20:35
@raubitsj raubitsj merged commit 2fc881c into master Apr 27, 2022
@raubitsj raubitsj deleted the WB-9395 branch April 27, 2022 22:32
@raubitsj raubitsj changed the title [WB-9395] Fixes duplicate backtrace when using service Fix duplicate backtrace when using wandb-service May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants