Conversation
Codecov Report
@@ Coverage Diff @@
## master #3574 +/- ##
==========================================
+ Coverage 81.54% 81.56% +0.02%
==========================================
Files 240 240
Lines 29508 29502 -6
==========================================
+ Hits 24061 24064 +3
+ Misses 5447 5438 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-9397
Description
What does the PR do?
When using service and console logging with large input the data is not sent properly and get corrupted as a result the execution fails and the program hangs. If we replace
sendwithsendallwe are guaranteed either all data is sent or we getNone.Testing
How was this PR tested?
Resolved test: https://github.com/wandb/client/blob/master/tests/test_redir.py#L287. We can also add a dedicated functional test with service, but it seems to be already covered by the linked test.