Conversation
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
==========================================
- Coverage 81.55% 81.51% -0.05%
==========================================
Files 240 240
Lines 29506 29508 +2
==========================================
- Hits 24064 24052 -12
- Misses 5442 5456 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wandb.init is interrupted mid setup with service on
raubitsj
reviewed
Apr 27, 2022
| if log_dir: | ||
| # printer = printer or get_printer(settings._jupyter) | ||
| log_dir = os.path.dirname(log_dir.replace(os.getcwd(), ".")) | ||
| log_dir = os.path.dirname(log_dir) |
Contributor
There was a problem hiding this comment.
Seems like the old behavior of showing a relative path was nicer:
OLD:
wandb: Find logs at: ./wandb/run-20220427_161225-3tz4bz6z/logs
NEW:
wandb: Find logs at: /Users/jeff/work/wb/client/functional_tests/core/wandb/run-20220427_161208-2893jyzh/logs
Collaborator
Author
There was a problem hiding this comment.
sure I can undo this change...
wandb.init is interrupted mid setup with service onwandb.init is interrupted mid setup using wandb-service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-9386
Description
What does the PR do?
when service enabled and code fails during
wandb.initbefore this PR it would hang because we would clean up the backend hence unable to properly terminate the program withservicethis PR fixes this issue, by gating cleaning backend only in the non-service caseTesting
How was this PR tested?