Fix regression: disable saving history step in artifacts#3495
Merged
raubitsj merged 7 commits intorelease-0.12.14from Apr 8, 2022
Merged
Fix regression: disable saving history step in artifacts#3495raubitsj merged 7 commits intorelease-0.12.14from
raubitsj merged 7 commits intorelease-0.12.14from
Conversation
Codecov Report
@@ Coverage Diff @@
## release-0.12.14 #3495 +/- ##
===================================================
+ Coverage 81.71% 81.72% +0.01%
===================================================
Files 236 236
Lines 29114 29115 +1
===================================================
+ Hits 23791 23795 +4
+ Misses 5323 5320 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
raubitsj
reviewed
Apr 8, 2022
Contributor
There was a problem hiding this comment.
This change looks fine.. but before this can be merged and released, the following things need to happen:
- This PR needs to be merged: https://github.com/wandb/core/pull/9212
- gorilla deployed to prod
- this change tested against prod (verified to pass history step - with debug messages?)
- this change tested against local (verified not to pass history step - with debug messages?)
Alternatively:
- a fix which removes history step does not need any changes to core or any gorilla deploys.
raubitsj
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-NNNN
Fixes #NNNN
Description
What does the PR do?
For context, we added the latest history step to the mutation that creates an artifact. This change was put in less than a month ago in the backend. The corresponding SDK PR was merged at the same time.
A Local user reported the following error when they switched to SDK versions 0.12.12 or 0.12.13. They stated that the error did not happen with 0.12.11:
This PR adds max_cli_version guardrails (0.12.12) for when history step was introduced in the SDK. Basically, it grabs the max_cli_version that the backend (either cloud or local) knows about and makes sure that we only include the history step info into the gql query if this max_cli_version >= 0.12.12.
We tested the following script against a version of local that is 2 months old:
Initially, we hard-coded
can_handle_historyto be True, in order to trigger the GraphQL query with the added history step and error out (since a 2-month old version of local wouldn't have history in the schema). The gql query fails (as it should) and the artifact is not logged. However, the run finishes successfully (and fails silently without alerting the user, which is a separate issue).With the guardrail,
can_handle_historybecomes false and the artifact is logged successfully.Testing
This is a hotfix, in response to an issue that Local users would be experiencing.
It was tested manually against an old local release, as stated above.
In the future, we need to figure out a way to test this with unit tests, and also with regression tests against the last 5 (or other number) versions of local.
This PR adds a standalone test that is meant to be tested against local versions (and verify that the guardrail does indeed work and successfully logs an artifact).
Checklist