Skip to content

Add args_no_boolean_flags macro to sweep configuration#3489

Merged
hu-po merged 16 commits intomasterfrom
feature/args-boolean-flags
Apr 15, 2022
Merged

Add args_no_boolean_flags macro to sweep configuration#3489
hu-po merged 16 commits intomasterfrom
feature/args-boolean-flags

Conversation

@hu-po
Copy link
Copy Markdown
Contributor

@hu-po hu-po commented Apr 7, 2022

Fixes WB-3809
Fixes #NNNN

Description

Adds an args_no_boolean_flags macro which will omit boolean parameters with a False value when passing them to a run command.

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2022

Codecov Report

Merging #3489 (f6d5380) into master (4802605) will increase coverage by 0.01%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
+ Coverage   81.41%   81.42%   +0.01%     
==========================================
  Files         236      236              
  Lines       29062    29082      +20     
==========================================
+ Hits        23661    23681      +20     
  Misses       5401     5401              
Flag Coverage Δ
functest 58.11% <10.34%> (+<0.01%) ⬆️
unittest 71.57% <75.86%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/wandb_agent.py 21.33% <75.86%> (+4.99%) ⬆️
wandb/sdk/internal/artifacts.py 83.15% <0.00%> (-3.16%) ⬇️
wandb/filesync/step_prepare.py 92.85% <0.00%> (-1.43%) ⬇️
wandb/sdk/internal/internal_api.py 83.55% <0.00%> (-0.41%) ⬇️
wandb/sdk/wandb_run.py 89.90% <0.00%> (-0.07%) ⬇️
wandb/sdk/lib/git.py 76.19% <0.00%> (ø)
wandb/sdk/internal/stats.py 67.59% <0.00%> (+0.55%) ⬆️
wandb/sdk/internal/meta.py 90.68% <0.00%> (+3.10%) ⬆️

@hu-po hu-po force-pushed the feature/args-boolean-flags branch from 1e60626 to 30b08c5 Compare April 8, 2022 15:04
@hu-po hu-po requested a review from raubitsj April 15, 2022 18:48
Copy link
Copy Markdown
Contributor

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hu-po hu-po merged commit e3a26cf into master Apr 15, 2022
@hu-po hu-po deleted the feature/args-boolean-flags branch April 15, 2022 20:06
@raubitsj raubitsj changed the title [WB-3809] args_no_boolean_flags macro Add args_no_boolean_flags macro to sweep configuration May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants