Skip to content

[WB-8920] Improve Launch deployable agent#3388

Merged
KyleGoyette merged 22 commits intomasterfrom
launch/deployable-agent-changes
Mar 28, 2022
Merged

[WB-8920] Improve Launch deployable agent#3388
KyleGoyette merged 22 commits intomasterfrom
launch/deployable-agent-changes

Conversation

@KyleGoyette
Copy link
Copy Markdown
Contributor

@KyleGoyette KyleGoyette commented Mar 16, 2022 •
edited
Loading

Fixes WB-8920

Description

  • reshuffles the agent to get its name and update before grabbing a run
  • makes the launch agent try to use the WANDB_PROJECT env var if no project is given
  • makes the launch agent resistant to death by exception
  • gets rid of the netrc file requirement when downloading a file through the internal api

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #3388 (d67c972) into master (1cae7af) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
+ Coverage   81.63%   81.67%   +0.04%     
==========================================
  Files         234      234              
  Lines       28807    28818      +11     
==========================================
+ Hits        23516    23538      +22     
+ Misses       5291     5280      -11
Flag Coverage Δ
functest 58.74% <5.00%> (+0.01%) ⬆️
unittest 71.70% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/launch.py 79.24% <ø> (ø)
wandb/cli/cli.py 66.47% <100.00%> (+0.19%) ⬆️
wandb/sdk/launch/agent/agent.py 94.16% <100.00%> (+0.87%) ⬆️
wandb/sdk/launch/docker.py 89.09% <100.00%> (+0.10%) ⬆️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.01% <0.00%> (+0.25%) ⬆️
wandb/filesync/step_prepare.py 94.28% <0.00%> (+1.42%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️

@KyleGoyette KyleGoyette marked this pull request as ready for review March 17, 2022 16:39
@KyleGoyette KyleGoyette requested a review from stephchen March 17, 2022 16:39
stephchen
stephchen approved these changes Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephchen stephchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a description (like a one liner you could just link the original prs) since this is going into master? otherwise good

@KyleGoyette KyleGoyette changed the title Launch/deployable agent changes [WB-8920] Launch deployable agent changes Mar 23, 2022
@KyleGoyette KyleGoyette requested a review from raubitsj March 25, 2022 18:09
@KyleGoyette KyleGoyette merged commit c42c130 into master Mar 28, 2022
@KyleGoyette KyleGoyette deleted the launch/deployable-agent-changes branch March 28, 2022 17:13
@raubitsj raubitsj changed the title [WB-8920] Launch deployable agent changes [WB-8920] Improve Launch deployable agent Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raubitsj raubitsj Awaiting requested review from raubitsj

1 more reviewer

@stephchen stephchen stephchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KyleGoyette @stephchen