[WB-7940] Fix excess warning span if requested WANDB_DIR/root_dir is not writable#3304
Merged
dmitryduev merged 35 commits intomasterfrom Mar 15, 2022
Merged
[WB-7940] Fix excess warning span if requested WANDB_DIR/root_dir is not writable#3304dmitryduev merged 35 commits intomasterfrom
dmitryduev merged 35 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
==========================================
+ Coverage 81.39% 81.41% +0.02%
==========================================
Files 234 234
Lines 28709 28719 +10
==========================================
+ Hits 23367 23383 +16
+ Misses 5342 5336 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
reviewed
Mar 15, 2022
| - wandb | ||
| tag: | ||
| skips: | ||
| - platform: win |
Member
Author
There was a problem hiding this comment.
heh, I don't know actually, it was there already, I just move it to a separate yea file :)
kptkin
reviewed
Mar 15, 2022
| - wandb | ||
| tag: | ||
| skips: | ||
| - platform: win |
kptkin
reviewed
Mar 15, 2022
| _instance = None | ||
|
|
||
| def __init__(self, settings=None): | ||
| def __init__(self, settings=None) -> None: |
Collaborator
There was a problem hiding this comment.
nit: do you want to type settings?
kptkin
reviewed
Mar 15, 2022
|
|
||
|
|
||
| def _setup(settings=None, _reset=None): | ||
| def _setup(settings=None, _reset: bool = False) -> Optional["_WandbSetup"]: |
kptkin
reviewed
Mar 15, 2022
| def setup(settings=None): | ||
| def setup(settings=None) -> Optional["_WandbSetup"]: | ||
| ret = _setup(settings=settings) | ||
| # wandb.termlog("`wandb` session started.", repeat=False) |
Collaborator
There was a problem hiding this comment.
do you want to remove commented out code?
kptkin
reviewed
Mar 15, 2022
|
|
||
|
|
||
| def setup(settings=None): | ||
| def setup(settings=None) -> Optional["_WandbSetup"]: |
Collaborator
There was a problem hiding this comment.
same do you want to type this?
Member
Author
There was a problem hiding this comment.
This file is still not type-annotated :( I would leave it for a future PR, we should organize a type-annotation sprint or something.
Collaborator
There was a problem hiding this comment.
yeah that's why i nitted it haha
kptkin
approved these changes
Mar 15, 2022
Collaborator
kptkin
left a comment
There was a problem hiding this comment.
Awesome! Such a pleasure to review your PRs!!!
dmitryduev
commented
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-7940
Description
In this PR:
wandb.login()(orwandb.setup()) beforewandb.init(), the singleton will already be set up and so if e.g. env vars are set/changed in between, they will be ignored, which might not be what the user expects.When running
wandb.init()we will now first check if the singleton exists and if so, check if the environment vars have changed and notify the user if they did.WANDB_DIR/root_dir) is not writable:Testing
Added a
yeatest.