Skip to content

Add setproctitle to requirements.txt#3289

Merged
raubitsj merged 1 commit intomasterfrom
add-setproctitle
Feb 24, 2022
Merged

Add setproctitle to requirements.txt#3289
raubitsj merged 1 commit intomasterfrom
add-setproctitle

Conversation

@raubitsj
Copy link
Copy Markdown
Contributor

@raubitsj raubitsj commented Feb 24, 2022

Description

Add setproctitle so we get cleaner internal process names
Current process is named something like this:

wandb-service(2-221522-s-33529)

Which encodes the service_version-user_pid-communication_method-port

Testing

This has been tested with pip install wandb[service] for a while, no reports of issues (though low use)

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@raubitsj raubitsj added this to the sdk-2022-03.1 milestone Feb 24, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2022

Codecov Report

Merging #3289 (821b76e) into master (1a98439) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3289      +/-   ##
==========================================
+ Coverage   80.10%   80.12%   +0.02%     
==========================================
  Files         214      214              
  Lines       28167    28167              
==========================================
+ Hits        22562    22569       +7     
+ Misses       5605     5598       -7     
Flag Coverage Δ
functest 56.77% <ø> (+0.01%) ⬆️
unittest 69.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/service/server_sock.py 91.66% <0.00%> (-1.05%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)
wandb/sdk/wandb_run.py 88.76% <0.00%> (+0.27%) ⬆️
wandb/sdk/internal/meta.py 90.74% <0.00%> (+3.08%) ⬆️

@raubitsj raubitsj merged commit 59c6229 into master Feb 24, 2022
@raubitsj raubitsj deleted the add-setproctitle branch February 24, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants