Wb 5493 windows table logging classes issue#3145
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3145 +/- ##
==========================================
+ Coverage 79.03% 79.06% +0.02%
==========================================
Files 210 210
Lines 27636 27640 +4
==========================================
+ Hits 21843 21853 +10
+ Misses 5793 5787 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…com:wandb/client into WB-5493-windows-table-logging-classes-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-5493
https://wandb.atlassian.net/browse/WB-5493
Simple repro:
Description
The error happens on Windows because of Windows' back-slashed paths. When we store an entry in an artifact's manifest, we convert its name to a forward-slashed path.
While adding another object to the artifact, we first check to see if an entry with that same path already exists in the manifest. In this case, because we didn't convert to forward slashes before checking, the check passed and we went ahead to open a new file --> this function threw an error because the file already exists.
This PR ensures that every target path in
Artifact.add_*is forward-slashed.Testing
How was this PR tested?
Checklist