WB-8032 - Stops users from creating Tables with invalid columns from dataframes#3113
Merged
WB-8032 - Stops users from creating Tables with invalid columns from dataframes#3113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3113 +/- ##
==========================================
+ Coverage 79.00% 79.02% +0.02%
==========================================
Files 210 210
Lines 27588 27590 +2
==========================================
+ Hits 21795 21803 +8
+ Misses 5793 5787 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-8032
Description
We were missing a format validation for columns created from dataframes which was resulting in invalid type processing downstream. In particular, Tables need int or string columns, but if created from a dataframe, we were skipping the type assertion. The result is that tables created with floating point columns get busted.
Testing
Manual testing - uses existing harnesses