fix: traceback in _numpy_arrays_to_lists when 0 dim np array is provided#2954
Merged
vanpelt merged 2 commits intowandb:masterfrom Nov 24, 2021
Merged
fix: traceback in _numpy_arrays_to_lists when 0 dim np array is provided#2954vanpelt merged 2 commits intowandb:masterfrom
vanpelt merged 2 commits intowandb:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2954 +/- ##
==========================================
+ Coverage 78.69% 78.72% +0.02%
==========================================
Files 194 194
Lines 26544 26544
==========================================
+ Hits 20890 20897 +7
+ Misses 5654 5647 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vanpelt
requested changes
Nov 24, 2021
Contributor
vanpelt
left a comment
There was a problem hiding this comment.
Awesome, thanks for the PR! Our linter is complaining about the trailing whitespace on line 2711. Can you merge in the latest master and fix the whitespace issue?
12026da to
108a905
Compare
Contributor
Author
|
@vanpelt Thank you for the prompt review! Fixed & rebased on top of the latest master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Function
_numpy_arrays_to_listsresulted in traceback when 0-dim numpy array was passed as a parameter. How to reproduce:The problem is the
.tolist()call. Explanation is in the numpy docs:Testing
PR includes one test scenario for this use-case. I was not sure what is the expected behaviour if it should return
[value]or scalarvalue. From the function definition it make sense to me that it is[value]but feedback is welcomed.