[WB-7396] add max-jobs and launch async args#2925
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
+ Coverage 78.67% 78.71% +0.04%
==========================================
Files 194 194
Lines 26549 26553 +4
==========================================
+ Hits 20887 20902 +15
+ Misses 5662 5651 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wandb.atlassian.net/browse/WB-7396
Description
Adds an
--asyncarg towandb launchso that launch can return without waiting for the job. Also adds a--max-jobsarg towandb launch-agentthat caps the number of parallel runs on the agent, which only runs asynchronously.Testing
added test
Release Notes
Below, please enter user-facing release notes as one or more bullet points.
If your change is not user-visible, write
NO RELEASE NOTESinstead, with no bullet points.------------- BEGIN RELEASE NOTES ------------------
NO RELEASE NOTES
------------- END RELEASE NOTES --------------------