Fix broken artifact string in launch init config#3582
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
==========================================
+ Coverage 81.58% 81.59% +0.01%
==========================================
Files 240 240
Lines 29523 29525 +2
==========================================
+ Hits 24086 24091 +5
+ Misses 5437 5434 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dmitryduev
approved these changes
Apr 28, 2022
Member
dmitryduev
left a comment
There was a problem hiding this comment.
Looks correct to me! Thanks @KyleGoyette :)
KyleGoyette
added a commit
that referenced
this pull request
Jun 1, 2022
KyleGoyette
added a commit
that referenced
this pull request
Jun 15, 2022
…ig during upsert run (#3734) * Revert "[WB-9452] Fix broken artifact string in launch init config (#3582)" This reverts commit 6bc40bd. * ini commit * re add tests * fix * fix * make _handle_launch_config a function rather than an _WandbInit method * fix final tests * remove unused code * fix settings source * make more readable Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com> Co-authored-by: Hugo <8493427+hu-po@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-9452
Fixes #NNNN
Description
Fixes an issue where in the launch context, passing in an artifact string would break the run.
Testing
How was this PR tested?
Checklist