Conversation
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
+ Coverage 81.54% 81.55% +0.01%
==========================================
Files 240 240
Lines 29508 29508
==========================================
+ Hits 24061 24064 +3
+ Misses 5447 5444 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
raubitsj
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WB-9364
Fixes #3542
Description
What does the PR do?
Fixes a hang issues that is caused by the fact that the same keyboardInterrupt is sent both to the service as well as the user process.
This fix is only valid for posix based OS (a fix for windows will be done in a separate PR)
Testing
How was this PR tested?
Manually test and verified that it actually terminates properly