Skip to content

fix py27 regression in data_types.py#1839

Merged
raubitsj merged 1 commit intomasterfrom
fix/datatypes-py27
Feb 15, 2021
Merged

fix py27 regression in data_types.py#1839
raubitsj merged 1 commit intomasterfrom
fix/datatypes-py27

Conversation

@raubitsj
Copy link
Copy Markdown
Contributor

@raubitsj raubitsj commented Feb 15, 2021

Description

regression was failing:

./do-local-regression.sh --spec wandb-standalone-simpsons_data_frames:init:py27 tests/main/
Traceback (most recent call last):
  File "simpsons_data_frames.py", line 155, in <module>
    run.summary.update({ "results3": results_data_frame(test_datagen, model) })
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/wandb_summary.py", line 79, in update
    self._update(record)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/wandb_summary.py", line 133, in _update
    self._update_callback(record)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/wandb_run.py", line 670, in _summary_update_callback
    self._backend.interface.publish_summary(summary_record)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/interface/interface.py", line 600, in publish_summary
    pb_summary_record = self._make_summary(summary_record)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/interface/interface.py", line 381, in _make_summary
    json_value = self._summary_encode(item.value, path_from_root)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/interface/interface.py", line 345, in _summary_encode
    self._run, path_from_root, value, namespace="summary"
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/data_types.py", line 2004, in val_to_json
    return _data_frame_to_json(val, run, key, namespace)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/data_types.py", line 2152, in _data_frame_to_json
    json.dumps(val_to_json(run, key, val, namespace=step))
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/data_types.py", line 2038, in val_to_json
    val.bind_to_run(run, key, namespace)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/data_types.py", line 1671, in bind_to_run
    super(Image, self).bind_to_run(run, key, step, id_)
  File "/home/raubitsj/.pyenv/versions/v2713/lib/python2.7/site-packages/wandb/sdk_py27/data_types.py", line 360, in bind_to_run
    assert isinstance(self._path, str)
AssertionError

Testing

Regression passes.

@raubitsj raubitsj changed the title fix py27 regression fix py27 regression in data_types.py Feb 15, 2021
@raubitsj raubitsj requested a review from tssweeney February 15, 2021 01:05
@raubitsj raubitsj marked this pull request as ready for review February 15, 2021 01:05
tssweeney
tssweeney approved these changes Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn strings. Looks good

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2021

Codecov Report

Merging #1839 (c86b141) into master (e65cef4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   70.93%   70.96%   +0.02%     
==========================================
  Files         226      226              
  Lines       26795    26795              
==========================================
+ Hits        19008    19016       +8     
+ Misses       7787     7779       -8
Impacted Files Coverage Δ
wandb/sdk/data_types.py 82.17% <100.00%> (ø)
wandb/sdk/lib/git.py 72.18% <0.00%> (ø)
wandb/filesync/dir_watcher.py 81.18% <0.00%> (+1.48%) ⬆️
wandb/sdk/internal/meta.py 85.90% <0.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65cef4...c86b141. Read the comment docs.

@raubitsj raubitsj merged commit 58bf416 into master Feb 15, 2021
@raubitsj raubitsj deleted the fix/datatypes-py27 branch February 15, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raubitsj @tssweeney