Skip to content

fix(breakpoints): prevent overlap on HiDPI displays#14358

Merged
KaelWD merged 2 commits intovuetifyjs:masterfrom
KareemDa:fix/14353
Nov 3, 2021
Merged

fix(breakpoints): prevent overlap on HiDPI displays#14358
KaelWD merged 2 commits intovuetifyjs:masterfrom
KareemDa:fix/14353

Conversation

@KareemDa
Copy link
Copy Markdown
Contributor

@KareemDa KareemDa commented Nov 2, 2021

Description

fixes #14353
in display-breakpoints there were -1 in some sizes which causes the problem:
image

I've changed it into 0.02

output:
image

Motivation and Context

How Has This Been Tested?

Markup:

Details
<template>
  <v-app>
    <p class="hidden-md-only">hidden-md text: should be hidden on md devices</p>
    <p class="hidden-lg-only">hidden-lg text: should be hidden on lg devices</p>
    <p>device: {{ $vuetify.breakpoint.name }}</p>
    <p>$vuetify.breakpoint.md: {{ $vuetify.breakpoint.md }}</p>
    <p>$vuetify.breakpoint.lg: {{ $vuetify.breakpoint.lg }}</p>
  </v-app>
</template>

<script>
export default {
  data: () => ({
    //
  }),
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD
Copy link
Copy Markdown
Member

KaelWD commented Nov 3, 2021

Please use proper titles on your PRs

@KaelWD KaelWD changed the title fix: #14353 fix(breakpoints): prevent overlap on HiDPI displays Nov 3, 2021
@KaelWD KaelWD merged commit e3f28a4 into vuetifyjs:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report][2.5.10] Hidden-{breakpoint} classes overlap each other in some edge cases

2 participants