fix(VCombobox): keep highlighted item on filteredItems change#14196
fix(VCombobox): keep highlighted item on filteredItems change#14196KaelWD merged 3 commits intovuetifyjs:masterfrom
Conversation
|
This does fix example 3 from #14194, but example 1 isn't fixed and example 2 is fixed visually but still emits the incorrect index. |
|
@KaelWD A comment was left in issue #14194. Generally speaking, the issue is from |
|
Fix has been done in In addition, test cases are added to simulate both #14194 & #6607 to ensure this pull request does fix #14194 and does not introduce breaking changes to #6607 |
|
|
||
| this.$nextTick(this.updateSelf) | ||
| }, | ||
| onFilteredItemsChanged (val: never[], oldVal: never[]) { |
There was a problem hiding this comment.
Initial purpose of having this function overrided can be found from this commit c84c2fb

As per my testing, after removing this function, in combobox, entering custom words that may loosely match items in the list remains working correctly.
In addition, ultimately, in terms of filteredItems watcher which is used to handle auto selection logic, it should behave the same for VAutocomplete & VCombobox ?
fixes #14194 #6607
Description
This pull request fixes #14194 as well as keeps fixing #6607
Test cases are added to cover both #14194 & #6607
Motivation and Context
resolves #14194
How Has This Been Tested?
visually | unit
Markup:
Details
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).