Skip to content

chore: Optimize Go CI workflows#2829

Merged
embano1 merged 1 commit intovmware:masterfrom
embano1:issue-2828
Apr 27, 2022
Merged

chore: Optimize Go CI workflows#2829
embano1 merged 1 commit intovmware:masterfrom
embano1:issue-2828

Conversation

@embano1
Copy link
Copy Markdown
Contributor

@embano1 embano1 commented Apr 26, 2022 •
edited
Loading

Description

  • Caching per go version
  • Cancel long-running workflows, e.g. build when concurrent jobs are queued (only for PRs)
  • Do not fail on matrix tests

Closes: #2828
Signed-off-by: Michael Gasch mgasch@vmware.com

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • CI passes and PR synchronization (pushes) cancel build/govc tests workflows

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@embano1 embano1 force-pushed the issue-2828 branch 2 times, most recently from 0f6137d to 801a251 Compare April 26, 2022 09:53
chore: Optimize Go CI workflows
d60b21d 
Closes: vmware#2828
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 requested a review from dougm April 26, 2022 09:58
@embano1 embano1 marked this pull request as ready for review April 26, 2022 09:58
@embano1 embano1 merged commit 4c6c565 into vmware:master Apr 27, 2022
@embano1 embano1 deleted the issue-2828 branch April 27, 2022 06:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2025

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dougm dougm dougm approved these changes

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize Go CI workflows

3 participants

@embano1 @dougm @vmwclabot