Skip to content

Callmap validation ignore list cleanup#8144

Merged
orklah merged 8 commits intovimeo:4.xfrom
SamMousa:feature-check-unused-callmap-ignore
Jun 22, 2022
Merged

Callmap validation ignore list cleanup#8144
orklah merged 8 commits intovimeo:4.xfrom
SamMousa:feature-check-unused-callmap-ignore

Conversation

@SamMousa
Copy link
Copy Markdown
Contributor

@SamMousa SamMousa commented Jun 22, 2022

This PR:

  • Cleans up the ignore list in the callmap validation
  • Replaces prefix ignores with individual ignores
  • Add a "negative" test to ensure that ignored functions still need to be ignored

@SamMousa
Copy link
Copy Markdown
Contributor Author

SamMousa commented Jun 22, 2022

This is ready for review!

@SamMousa SamMousa marked this pull request as ready for review June 22, 2022 13:37
@AndrolGenhald AndrolGenhald added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jun 22, 2022
orklah
orklah reviewed Jun 22, 2022
View reviewed changes
Comment thread tests/Internal/Codebase/InternalCallMapHandlerTest.php Outdated
SamMousa
SamMousa commented Jun 22, 2022
View reviewed changes
Comment thread tests/Internal/Codebase/InternalCallMapHandlerTest.php Outdated
@orklah
Copy link
Copy Markdown
Collaborator

orklah commented Jun 22, 2022

Thanks!

@orklah orklah merged commit 1f87a50 into vimeo:4.x Jun 22, 2022
@SamMousa SamMousa mentioned this pull request Aug 29, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orklah orklah orklah left review comments

Assignees

No one assigned

Labels

release:internal The PR will be included in 'Internal changes' section of the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamMousa @orklah @AndrolGenhald